Enable tokenizers in shortfin packages on Linux x86_64. #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679.
Multi-arch support is hacky at the moment, but we are only building for x86_64 today and not aarch64. I think the ideal path forward there is to publish our own multi-platform images that include all of our deps (including rust and ccache), so I started on that with ScottTodd/nod-ai-base-docker-images@bdc5cc5. Another option is to continue using the upstream manylinux dockerfiles and install more deps on-demand like
yum install -y rust cargo
).Tested package build times and sizes:
Dev package builds will be used for #584, so keeping those times low is a priority. Could disable tokenizers there, at least as long as using the native tokenizers library is optional
Observations: