-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sharktank] Extend to test with Python 3.12 #693
Conversation
6e80f5d
to
e52a7d1
Compare
e52a7d1
to
a22b1ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I made some small edits to the PR description and left some suggestions for abbreviating the job names
.github/workflows/ci-sharktank.yml
Outdated
@@ -26,8 +26,17 @@ jobs: | |||
name: "Unit Tests and Type Checking" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed to "Unit Tests" for now but we probably want to harmonize this more across different workflows in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to "Unit Tests :: ${{ matrix.os }}, ${{ matrix.python-version }}, ${{ matrix.torch-version }}"
as for Windows it was (windows-2022, 3.11, 2.3.0)
and now have the same order for all jobs. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the ordering helps too. I think having two versions right next to each other can be confusing unless you are very familiar with Python and PyTorch versions. I personally have to unpack 3.11, 2.4.1
and think for a second, compared to 3.11, torch 2.4.1
. We don't have many characters to spare in the UI though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Save another character but we should aim to harmonize the naming in a follow up.
503a565
to
402e2cc
Compare
402e2cc
to
d435d97
Compare
Progress on #357
Extends to test with Python 3.12 and newer
torch
versions on Linux.For
torch.compile
support on Python 3.12, torch ge 2.4.0 is required. Testing with torch 2.3.0 is therefore skipped when running Python 3.12. To limit the number of jobs, tests are currently only expanded for Linux, whereas Windows (and unpinning NumPy) should be handled in a follow up.The error logged for
testExportNondecomposed
when failing with torch 2.5.1 slows down the CI by more than 20 minutes, therefore the test is now skipped instead of marked xfail.