Add unit test summary jobs to sharktank and shortfin workflows. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Dec 13, 2024
Comment on lines
+157
to
+168
| - name: Getting failed jobs | ||
| run: | | ||
| echo '${{ toJson(needs) }}' | ||
| FAILED_JOBS="$(echo '${{ toJson(needs) }}' \ | ||
| | jq --raw-output \ | ||
| 'map_values(select(.result!="success" and .result!="skipped")) | keys | join(",")' \ | ||
| )" | ||
| echo "failed-jobs=${FAILED_JOBS}" >> $GITHUB_OUTPUT | ||
| if [[ "${FAILED_JOBS}" != "" ]]; then | ||
| echo "The following jobs failed: ${FAILED_JOBS}" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
This failed jobs list code is forked from IREE. We could simplify for cases where there is only one job or we aren't using the GITHUB_OUTPUT (e.g. to send an alert to an external service).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #357.
This gives us a single job in each unit test workflow to set as a "required check" that will block merging, replacing the current single
Unit Tests (3.11, 2.3.0, ubuntu-24.04)check:I'm also switching ci-libshortfin.yml to run on all changes, which is a requirement for making a check required. We could still conditionally skip jobs based on paths modified... just not using GitHub's built in path filtering.