Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shark-ai] Include sharktank in the meta package #701

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Dec 16, 2024

No description provided.

@marbre
Copy link
Collaborator Author

marbre commented Dec 16, 2024

The downside right now is that


is pulled in from PyPI which comes with a lot of dependencies and we cannot point to the e.g. CPU-only version if we want to publish the meta package on PyPI.

@ScottTodd
Copy link
Member

The downside right now is that

is pulled in from PyPI which comes with a lot of dependencies and we cannot point to the e.g. CPU-only version if we want to publish the meta package on PyPI.

iree-turbine also has that pin: https://github.com/iree-org/iree-turbine/blob/91d8f598ca4ae5927bc0a735e17c4af8fbfaf90d/setup.py#L110. We could switch all packages to not require torch directly and instead check at import time if it is installed

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should proceed with this and then trim the requirements (notably torch) in a follow-up (ideally before the next stable release).

We can also explore moving some deps into extras.

@marbre marbre enabled auto-merge (squash) December 16, 2024 22:50
@marbre marbre merged commit b151ffa into nod-ai:main Dec 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants