Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iree dependencies forward to include barrier changes #834

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rsuderman
Copy link
Contributor

No description provided.

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes. shortfin pin update is optional

FYI I'll have this update process automated once I can land #827. Current blocked on some permissions / github setup steps.

@@ -2,6 +2,6 @@

# Keep these versions synced with SHORTFIN_IREE_GIT_TAG in shortfin/CMakeLists.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also try to update

# Version pins for dependencies.
# Prefer to keep the IREE git tag synced with the Python package version in the
# requirements-iree-pinned.txt file. At a minimum, the compiler from those
# packages must be compatible with the runtime at this source ref.
set(SHORTFIN_IREE_GIT_TAG "iree-3.2.0rc20250113")
, or let it drift a bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you specifically want IREE runtime changes in shortfin, then you do need to update that, not just the python package requirements.

@ScottTodd
Copy link
Member

FYI I'll have this update process automated once I can land #827. Current blocked on some permissions / github setup steps.

Like so: #835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants