Adding conv igemm layout support - step 1: conv op matcher #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
reviewed
Feb 10, 2025
jerryyin
force-pushed
the
users/zyin/add-conv-op-matcher
branch
from
e904146 to
10ec7fe
Compare
Co-authored-by: Max Dawkins <[email protected]> Co-authored-by: jerryyin <[email protected]>
Signed-off-by: jerryyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convolution op matcher is originally implemented by @Max191. I've added bare minimal amount of implementation to allow it to be tested via dispatch parser test. This is a subset of #898 and as an attempt to reduce amount of changes in a single PR to facilitate code reviews.
Summary of changes:
ConvolutionDimensionsto host convolution fields information;ProblemSizethat will capture lhs/rhs and result affine expressions as well as conv dimensionConvolutionInterfaceMatcher