Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#218] QA: 요구사항 반영 #219

Merged
merged 2 commits into from
Jul 28, 2024
Merged

[#218] QA: 요구사항 반영 #219

merged 2 commits into from
Jul 28, 2024

Conversation

HoberMin
Copy link
Contributor

💬 Issue Number

closes #218

🤷‍♂️ Description

작업 내용에 대한 설명

  • 작성자 뱃지를 댓글작성자에서 게시글 작성자로 변경하였습니다.
  • 유저페이지의 뱃지 아래 텍스트 에서 사용자의 활동내역이 아닌 절대값으로 변경했습니다.

📋 Check List

PR 전 체크해주세요.

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?

📒 Remarks

팀원이 코드리뷰 시 주의할 점 또는 말하고 싶은 점 특이사항

@github-actions GitHub Actions
Copy link

🚀 Storybook is deployed! View it here: https://6621243cb767d61b79ad0f3c-edyucgzjif.chromatic.com/

hyeonjinan096
hyeonjinan096 approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@hyeonjinan096 hyeonjinan096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

ienrum
ienrum approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@ienrum ienrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@HoberMin HoberMin self-assigned this Jul 28, 2024
@HoberMin HoberMin merged commit 754b59f into main Jul 28, 2024
3 checks passed
@HoberMin HoberMin deleted the #218/QA/son branch July 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeonjinan096 hyeonjinan096 hyeonjinan096 approved these changes

@ienrum ienrum ienrum approved these changes

Assignees

@HoberMin HoberMin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] QA 수정사항 반영
3 participants
@HoberMin @hyeonjinan096 @ienrum