fix: Add Mongodb-watcher #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MRGUOKING <[email protected]> Add Mongodb-watcher Signed-off-by: MRGUOKING <[email protected]>
|
@chunfat-setsail @nodece @Zxilly plz review. |
|
Could plz also add support for module usage? |
nodece
reviewed
Jun 6, 2021
| "name": "mongodb-watcher", | ||
| "version": "1.0.0", | ||
| "description": "moggodb-watcher for node casbin", | ||
| "main": "index.js", |
nodece
reviewed
Jun 6, 2021
| private readonly collectionName: string; | ||
| public client: MongoClient; | ||
|
|
||
|
|
nodece
reviewed
Jun 6, 2021
| this.collectionName = collectionName; | ||
| } | ||
|
|
||
|
|
nodece
reviewed
Jun 6, 2021
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", |
There was a problem hiding this comment.
Please add Apache license to this project, and update ISC to Apache.
nodece
reviewed
Jun 6, 2021
| "ts-jest": "^27.0.2", | ||
| "typescript": "^4.3.2" | ||
| } | ||
| } |
|
Hi @MRGUOKING, your code has been reviewed. The following is todo list:
|
|
Setup eslint and prettier will be a good idea. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1
Signed-off-by: MRGUOKING [email protected]
Add Mongodb-watcher
Signed-off-by: MRGUOKING [email protected]