fix(help): prints subcmd menu correctly

#617
node-gh · Jan 9, 2019 · 3225516 · 3225516
1 parent 86543c6
commit 3225516
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/cmd.ts b/src/cmd.ts
@@ -6,8 +6,6 @@
 
 // -- Requires -------------------------------------------------------------------------------------
 
-// export const hi = 'hi'
-
 import * as async from 'async'
 import * as fs from 'fs'
 import * as nopt from 'nopt'

diff --git a/src/cmds/help.ts b/src/cmds/help.ts
@@ -149,27 +149,22 @@ Help.prototype.listFlags_ = function(command) {
 Help.prototype.listCommands_ = function(commands) {
     let content =
         'usage: gh <command> [payload] [--flags] [--verbose] [--no-color] [--no-hooks]\n\n'
-    let pos
-    let command
 
     content += 'List of available commands:\n'
 
-    for (pos in commands) {
-        if (commands.hasOwnProperty(pos)) {
-            command = commands[pos]
+    commands.forEach(command => {
+        if (command && command.hasOwnProperty('alias')) {
             content += '  '
 
-            if (command.alias) {
-                content += `${logger.colors.magenta(command.alias)}, `
-            }
+            content += `${logger.colors.magenta(command.alias)}, `
 
             content += `${logger.colors.magenta(command.name)}${command.offset}${
                 command.description
             }\n`
 
             content += this.listFlags_(command)
         }
-    }
+    })
 
     content += `\n(*) Flags that can execute an action.\n'gh help' lists available commands.\n'gh help -a' lists all available subcommands.`