Prevent stacktrace error

node-gh · Jun 4, 2013 · 8ad11e3 · 8ad11e3
1 parent 3803bc8
commit 8ad11e3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/lib/cmds/issue.js b/lib/cmds/issue.js
@@ -163,7 +163,12 @@ Issue.prototype.close = function(opt_callback) {
     var instance = this;
 
     instance.getIssue_(function(err, issue) {
-        instance.editIssue_(issue.title, Issue.STATE_CLOSED, opt_callback);
+        if (err) {
+            opt_callback && opt_callback(err);
+        }
+        else {
+            instance.editIssue_(issue.title, Issue.STATE_CLOSED, opt_callback);
+        }
     });
 };
 
@@ -297,7 +302,12 @@ Issue.prototype.open = function(opt_callback) {
     var instance = this;
 
     instance.getIssue_(function(err, issue) {
-        instance.editIssue_(issue.title, Issue.STATE_OPEN, opt_callback);
+        if (err) {
+            opt_callback && opt_callback(err);
+        }
+        else {
+            instance.editIssue_(issue.title, Issue.STATE_OPEN, opt_callback);
+        }
     });
 };
 

diff --git a/lib/cmds/pull-request.js b/lib/cmds/pull-request.js
@@ -516,8 +516,13 @@ PullRequest.prototype.open = function(opt_callback) {
     var instance = this;
 
     instance.getPullRequest_(function(err, pull) {
-        instance.updatePullRequest_(
-            pull.title, pull.body, PullRequest.STATE_OPEN, opt_callback);
+        if (err) {
+            opt_callback && opt_callback(err);
+        }
+        else {
+            instance.updatePullRequest_(
+                pull.title, pull.body, PullRequest.STATE_OPEN, opt_callback);
+        }
     });
 };