fix: throw error when source is not exists (#78)

node-modules · Dec 22, 2022 · 7785c72 · 7785c72
1 parent fc3a98b
commit 7785c72
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -78,6 +78,11 @@ exports.makeUncompressFn = StreamClass => {
   return (source, destDir, opts) => {
     opts = opts || {};
     opts.source = source;
+    if (!source) { // !source 和 sourceType中返回undeined对应
+      const error = new Error('Type is not supported, must be a file path, file buffer, or a readable stream');
+      error.name = 'IlligalSourceError';
+      throw error;
+    }
     if (destType(destDir) !== 'path') {
       const error = new Error('uncompress destination must be a directory');
       error.name = 'IlligalDestError';

diff --git a/test/zip/uncompress_stream.test.js b/test/zip/uncompress_stream.test.js
@@ -227,3 +227,18 @@ describe('test/zip/uncompress_stream.test.js', () => {
     });
   });
 });
+
+it('should emit error if uncompress source is undefined', done => {
+  const timeout = setTimeout(()=>{
+    done("uncompress timeout");
+  }, 1000);
+  try {
+    compressing.zip.uncompress(undefined, originalDir)
+      .finally(() => clearTimeout(timeout));
+  }catch(err) {
+    clearTimeout(timeout);
+    assert(err.name === 'IlligalSourceError');
+    assert(err.message === 'Type is not supported, must be a file path, file buffer, or a readable stream');
+    done();
+  }
+})