Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value is null should not validate #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

value is null should not validate #42

wants to merge 2 commits into from

Conversation

gaochengyidlmu
Copy link

I have the problem.

I want to set some value to null.
but it throw an error.

const rule = { transferDate: {type: 'string', required: false, allowEmpty: true}}

let someData = {transferDate: '2018-07-02'}

req.body = {transferDate: null}

{ message: 'should be a string', code: 'invalid', field: 'transferDate' }

@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #42   +/-   ##
======================================
  Coverage    99.5%   99.5%           
======================================
  Files           1       1           
  Lines         201     201           
  Branches       73      73           
======================================
  Hits          200     200           
  Misses          1       1
Impacted Files Coverage Δ
index.js 99.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadccb1...4d5e213. Read the comment docs.

@konglingwen94
Copy link

这么好的提案,为什么没有通过合并呢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants