Alpha5 #542
Merged
Alpha5 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kewei <[email protected]>
I fixed the long caplin's snapshot wait time
Fixed port value after erigontech#12102 (review)
I found these typos annoying, while debugging (and grepping) rewards in caplin, but forgot to include them in my original PRs.
handles first part of erigontech#11533 which relates to calling bridge.Unwind via Astrid
Moved code which set preverified files list from preverified.toml before torrent whitelist is generated. Fix for erigontech#12031
Ref - ethereum/EIPs#8889 (Issue board - erigontech#12106)
Moves spanProducersReader code down to the function that covers all use cases. Not all RPCs call `GetSnapshot`, which lead to errors when using Astrid.
- this PR experiments with a 2nd experimental version of docker build workflow...it eventually deletes that - the (original) docker build workflow is changed to invoke kurtosis-assertoor workflow, once it succeeds. - here's a [sample run](https://github.com/erigontech/erigon/actions/runs/11105470450/job/30851703289) - this had the experimental workflow call the kurtosis ci...
Co-authored-by: shota.silagadze <[email protected]>
…ks table (erigontech#12148) fixes ``` INFO] [09-30|16:59:20.466] aggregator unwind step=2940 txUnwindTo=4595202440 stepsRangeInDB="accounts:0.9, storage:0.9, code:0.9, commitment:0.0, receipt:0.9, logaddrs: 0.9, logtopics: 0.9, tracesfrom: 0.9, tracesto: 0.9" [EROR] [09-30|16:59:20.671] Staged Sync err="[3/9 BorHeimdall] unexpected missing first processed block info entry when unwinding" ``` that table is only populated as part of astrid, so bor heimdall stage should not attempt to unwind it
Implement ethereum/EIPs#8845, which is part of [pectra-devnet-4](https://notes.ethereum.org/@ethpandaops/pectra-devnet-4)
Co-authored-by: shota.silagadze <[email protected]>
Better separation between testing and linting. Failed test CI only goes red for failed tests.
…#12073) Checked against beaconcha.in, against a synced prysm, and against ethereum-beacon-api.publicnode.com. Catlin is consistently off-by-one (one has to ask for the next numbered epoch to get calculation for the one that one wanted). @Giulio2002
- remove unused block - fromJson is not required to get os value
…#12173) fixes a crash when running astrid ``` [DBUG] [10-02|04:14:04.330] Error while executing stage err="[2/6 PolygonSync] stopped: service unavailable: url='https://heimdall-api-amoy.polygon.technology/milestone/count', status=503" [EROR] [10-02|04:14:04.330] [2/6 PolygonSync] stopping node err="service unavailable: url='https://heimdall-api-amoy.polygon.technology/milestone/count', status=503" ```
) Block bodies no longer have requests after PR erigontech#12370
1. accelerate scanning files by avoiding doubly nested loop 2. ~~do not reopen~~ (achieved by erigontech#12332 and erigontech#12362, so remove relevant code here)
Fixed ```MDBX_TXN_OVERLAPPING: Overlapping read and write transactions for the current thread, label: chaindata, trace: [kv_mdbx.go:782 kv_mdbx.go:935 aggregator.go:1959 aggregator.go:1635 exec3.go:369 stage_execute.go:164 stage_execute.go:254 default_stages.go:238 sync.go:531 sync.go:410 forkchoice.go:453 asm_amd64.s:1695]"``` --------- Co-authored-by: alex.sharov <[email protected]>
Use FlatRequest instead of a different type - DepositRequest defined earlier. This allows all request to align, with the differences in Deposit Requests separated out into functions rather than receiver methods. Tasks board: erigontech#12106
…erigontech#12436) We want to get the state at the end of the block when executing state sync events. `CreateHistoryStateReader` gives us the state before the transaction at `txIndex` is executed, so we want to get the state at `txIndex=len(transactions)`.
Create split between new and old code for easier removal later on. This also handles divergent behaviour for `bor_getSnapshotProposerSequence`.
Syncing to `master` branch in `interfaces` repo and adding back missing proto updates in erigontech#11962 --------- Co-authored-by: Shoham Chakraborty <[email protected]>
Fixes the issue when json decoding empty requests in param to `newPayload`, spefically, the following would keep coming up in Hive tests (EEST) ``` Exception: Error calling JSON RPC newPayloadV4, code: -32602, message: invalid argument 3: illegal base64 data at input byte 0 ```
erigontech#12441) …ature verification Co-authored-by: shota.silagadze <[email protected]>
fix some function names in comment
…xes (erigontech#12380) FYI: Next step will be: replace `visibleMutex` by `atomic.Pointer`
… in `backend.go` (erigontech#12413) I found that external RPCDaemon using custom logic/methods to open `engine` db and create `engine` object. Need re-use logic (and don't loose `.Accede()` when opening databases from external rpcdaemon) on Gnosis: next request doesn't work if `optimize=false` and works if `optimize=true`: ``` curl -X POST http://localhost:8549 -H 'Content-Type: application/json' -d '{"jsonrpc": "2.0", "method": "eth_getTransactionReceipt", "params": ["0x7fb21774eed37fa229d59cdf4b991f951aee185066d86b432ed1cc1e29764577"], "id": 293}' ``` for: erigontech#12247 error message is: ``` WARN[10-22|08:12:17.321] [rpc] served conn=127.0.0.1:35698 method=eth_getTransactionReceipt reqid=293 err="getReceipt error: ReceiptGen.GetReceipt: bn=19040024, txnIdx=0, fee cap less than block base fee: address 0x67342Ec1440bFB760Ba9805a7735e0D12Bb9fEc7, gasFeeCap: 0 baseFee: 141015840" ```
…12492) Cache is branch-specific. For pull-requests based on some feature-branch we can skip cache and save available space on our workflow cache as well as time required to run workflow.
I just had to bypass a cache :P
As the title described
Reproduce in sepolia, `rm-state --domain=receipt` and then` run stage_custom_trace`. when exec.workers > 1, `[EROR] [10-25|06:17:05.577] ReadHeaderRLP failed err="mdbx_get: MDBX_THREAD_MISMATCH: A thread has attempted to use a not owned object, e.g. a transaction that started by another thread"` BTW, after this the commit, the generate domain receipt file are same, but history file have different torrent_hash.
This is a non-functional refactor of ExecV3 which moves the parallel execution code out on the main function and puts it in a separate type/file This is to facilitate parallel execution testing/development without merge clashes
setunapo
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.