Skip to content

Commit

Permalink
fix(dcellar-web-ui): compatiable with metamask eip-712 signature (#397)
Browse files Browse the repository at this point in the history
* fix(dcellar-web-ui): compatiable with metamask eip-712 signature

* docs(dcellar-web-ui): update changelog
  • Loading branch information
devinxl authored Sep 20, 2024
1 parent d795ae0 commit 9507eb3
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 35 deletions.
12 changes: 12 additions & 0 deletions apps/dcellar-web-ui/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
{
"name": "dcellar-web-ui",
"entries": [
{
"version": "1.7.5",
"tag": "dcellar-web-ui_v1.7.5",
"date": "Thu, 19 Sep 2024 08:01:12 GMT",
"comments": {
"patch": [
{
"comment": "Compatiable with metamask eip-712 signature"
}
]
}
},
{
"version": "1.7.4",
"tag": "dcellar-web-ui_v1.7.4",
Expand Down
9 changes: 8 additions & 1 deletion apps/dcellar-web-ui/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Change Log - dcellar-web-ui

This log was last generated on Thu, 19 Sep 2024 07:13:05 GMT and should not be manually modified.
This log was last generated on Thu, 19 Sep 2024 08:01:12 GMT and should not be manually modified.

## 1.7.5
Thu, 19 Sep 2024 08:01:12 GMT

### Patches

- Compatible with metamask eip-712 signature

## 1.7.4
Thu, 19 Sep 2024 07:13:05 GMT
Expand Down
4 changes: 2 additions & 2 deletions apps/dcellar-web-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dcellar-web-ui",
"version": "1.7.4",
"version": "1.7.5",
"private": false,
"scripts": {
"dev": "node ./scripts/dev.js -p 3200",
Expand All @@ -19,7 +19,7 @@
"antd": "5.11.0",
"ahooks": "3.7.7",
"hash-wasm": "4.10.0",
"@bnb-chain/greenfield-js-sdk": "2.1.0-alpha.2",
"@bnb-chain/greenfield-js-sdk": "2.2.0-alpha.0",
"@bnb-chain/greenfield-cosmos-types": "0.4.0-alpha.32",
"@emotion/react": "^11.10.5",
"@emotion/styled": "^11.10.5",
Expand Down
9 changes: 0 additions & 9 deletions apps/dcellar-web-ui/src/modules/bucket/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ import { PageTitle } from '@/components/layout/PageTitle';
import { DiscontinueBanner } from '@/components/common/DiscontinueBanner';
import { BucketOperations } from '@/modules/bucket/components/BucketOperations';
import { GAContextProvider } from '@/context/GAContext';
import { useAccount } from 'wagmi';

export const BucketPage = () => {
const dispatch = useAppDispatch();
const loginAccount = useAppSelector((root) => root.persist.loginAccount);
const hasDiscontinueBucket = useAppSelector(selectHasDiscontinueBucket(loginAccount));

const documentVisibility = useDocumentVisibility();
const { connector } = useAccount();

useUpdateEffect(() => {
if (documentVisibility !== 'visible') return;
Expand All @@ -34,13 +32,6 @@ export const BucketPage = () => {
<PageTitle title={'Buckets'} metaTitle={'Buckets'}>
<CreateBucket />
</PageTitle>
{connector?.id === 'metaMask' && (
<DiscontinueBanner
content="Greenfield and the Metamask extension are facing compatibility issues affecting functionalities like bucket creation on Dcellar. The BNB Chain team is working on a hotfix, expected to be released by September 23rd."
height={44}
marginBottom={16}
/>
)}
{hasDiscontinueBucket && (
<DiscontinueBanner
content="Some items were marked as discontinued and will be deleted by SP soon. Please backup your data in time. "
Expand Down
9 changes: 0 additions & 9 deletions apps/dcellar-web-ui/src/modules/object/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import { ObjectOperations } from '@/modules/object/components/ObjectOperations';
import { BucketStatus as BucketStatusEnum } from '@bnb-chain/greenfield-js-sdk';
import { DiscontinueBanner } from '@/components/common/DiscontinueBanner';
import { MigratingBucketNoticeBanner } from './components/MigratingBucketNoticeBanner';
import { useAccount } from 'wagmi';

export const ObjectsPage = () => {
const dispatch = useAppDispatch();
Expand All @@ -44,7 +43,6 @@ export const ObjectsPage = () => {
const isBucketDiscontinue = useAppSelector((root) => root.bucket.isBucketDiscontinue);
const isBucketMigrating = useAppSelector((root) => root.bucket.isBucketMigrating);
const allSpList = useAppSelector((root) => root.sp.allSpList);
const { connector } = useAccount();

const { path } = router.query;
const items = path as string[];
Expand Down Expand Up @@ -132,13 +130,6 @@ export const ObjectsPage = () => {

<ObjectFilterItems />

{connector?.id === 'metaMask' && (
<DiscontinueBanner
content="Greenfield and the Metamask extension are facing compatibility issues affecting functionalities like bucket creation on Dcellar. The BNB Chain team is working on a hotfix, expected to be released by September 23rd."
height={44}
marginBottom={16}
/>
)}
{isBucketOwner ? (
<InsufficientBalance />
) : (
Expand Down
30 changes: 16 additions & 14 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9507eb3

Please sign in to comment.