WIP - Reference Validation #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stebanos
reviewed
Feb 24, 2018
js/core.js
Outdated
| } | ||
| } | ||
| phrases.forEach(function(item){ | ||
| if(item.key === "root"){ |
There was a problem hiding this comment.
Not just 'root', all phrases need to be checked.
stebanos
reviewed
Feb 24, 2018
js/core.js
Outdated
| phrases.forEach(function(item){ | ||
| if(item.key === "root"){ | ||
| item.values.forEach(function(i){ | ||
| let p = parsePhrase(i); |
There was a problem hiding this comment.
Why are you calling parsePhrase? The source has already been parsed at this point.
stebanos
reviewed
Feb 24, 2018
js/core.js
Outdated
| } | ||
| }); | ||
| references.forEach(function(item){ | ||
| if(!phraseBook[item]){ |
There was a problem hiding this comment.
Also, a key can also be a reference to something stored in localMemory, like this:
root:
- {{ dosomething(123) }}
dosomething(num):
- I have to do {{ num }} things.
num is also a key but doesn't refer to a phrase, but in your check it will throw an error.
|
Wait, I just realized that there is an issue with this. It is giving some error. |
|
This only considers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #17
There is an issue with this. When I change a seed on a sketch with invalid reference, it says
this.phraseBookis undefined