-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notable change description text format #1068
Notable change description text format #1068
Comments
cc @nodejs/releasers @nodejs/tsc |
I'd rather have the bot provide a more detailed explanation on how to write the notable change: ```notable-change
this PR does this and that
``` This can also be easy for automation to extract |
I would suggest instead: <details open><summary>Notable change</summary>
This PR does this and that.
</details> That way, GH will interpret the markdown as such, making it more likely to spot formatting mistakes, and making it more pleasing for humans looking at the PR. Example: Notable changeThis PR does this and that. |
LGTM Antoine suggesiton. |
I was reading some react PR which follows https://github.com/facebook/react/blob/main/.github/PULL_REQUEST_TEMPLATE.md and I wonder if we should just make it part of the pull request template so that all PRs, not just the notable changes ones, should follow a template, and should be followed when the author opens the PR and edits the PR message before they push the submit button. Then we just need designate a block in the template to be the part that'll be used in the release announcement if it's a notable change. So that can be something like:
And when the notable change label is applied, the bot makes it extra clear that the author should follow the template and try to put whatever that goes into the release announcement in the summary section. |
Spinning off from #1063 (comment) , when the notable-change label is applied, the bot says:
But it's still not very clear what you are supposed to do - at least my interpretation is that one should just edit the PR description and the release announcement will copy whatever that's in the PR description, but it seems that's rarely the case. In the past notable changes PR I see people do all sorts of random stuff based on their own interpretation of what the bot says, and in the past release announcements I've also seen summaries that didn't match any of the things people did in the PR. There are many notable change PRs with well-formed descriptions which don't get copy pasted into the release announcement, presumably because they don't match some unspecified format to indicate that the descriptions they prepared are the text that are supposed to be copied.
To copy what I discussed with @aduh95 on slack
A proposed format that would be automatable:
And the automation will replace "This pull request" with "This release" for the text summaries, leading to
In the bluesky post draft generated for the release, it will be something like
In the blog post and changelog etc. draft generated, it will just include whatever in that starts/ends block, and replace "This pull request" with "This release", and leave it for people to make the wording look less weird for a release announcement.
If we want to go with the less-human readable but more explicit about what's automated route, or allow multiple summaries in one PR (I imagine this would be generated by something like
git node release summary
, and I modeled it after what's used by https://github.com/nodejs/node-core-utils/blob/main/docs/ncu-team.md).(I am not sure whether this is too cryptic, but anyway just to kick off some discussion about how to actually specify an automatable format instead of continue leaving it open to interpretation).
The text was updated successfully, but these errors were encountered: