Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-node): add support for auto-fill Notable Changes section #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 23, 2024

Allows PR author (or repo maintainers) to define themselves the Notable Change using a <details> section in the PR description.

We should also update the workflow that comments when the label is added to add the instructions.

Fixes: nodejs/Release#1068

Allows PR author (or repo maintainers) to define themselves the
Notable Change using a `<details>` section in the PR description.
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (4bd6820) to head (569468e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          39       39           
  Lines        4676     4676           
=======================================
  Hits         3745     3745           
  Misses        931      931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the regex patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notable change description text format
2 participants