Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] failure #991

Closed
aduh95 opened this issue Sep 29, 2023 · 6 comments · Fixed by #992
Closed

[email protected] failure #991

aduh95 opened this issue Sep 29, 2023 · 6 comments · Fixed by #992

Comments

@aduh95
Copy link

aduh95 commented Sep 29, 2023

  • Node Version: 21.0.0-pre
  • CitGM Version: 9.0.2
  • Platform: all

error: Invalid version: "21.0.0-pre"

/cc @reconbot
@Trott
Copy link
Member

Trott commented Sep 29, 2023

Known issue. See: #959 (comment).

@Trott
Copy link
Member

Trott commented Sep 29, 2023

Whoops, I hit enter too soon:

Known issue. See:

#959 (comment) (explains failure)
#959 (comment) (explains why it's probably OK to keep it in CITGM anyway)
evanw/esbuild#3388 (issue on esbuild for the problem)
evanw/esbuild@ea9c644 (the fix in esbuild)

Oh, hey, @reconbot, it looks like the version of esbuild that should provide a fix was released two days ago and serialport in GitHub has that update. Do you think it would be OK for CITGM to install serialport from the GitHub main branch rather than the last published version? Or are you planning on releasing a new version of serialport imminently? (And do you know if you have to do anything to get the -pre issue fixed or if it just magically works with [email protected]?)

Trott added a commit that referenced this issue Sep 29, 2023
@Trott
lookup: use GitHub head for serialport
2ba9adf 
This will hopefully fix serialport when run against a `-pre`
version of Node.js. Eventually, this fix will be in a release
of serialport, but it's in GitHub now.

Closes: #991
@Trott Trott mentioned this issue Sep 29, 2023
Merged
2 tasks
@Trott
Copy link
Member

Trott commented Sep 29, 2023

Hopefully #992 fixes it, but we'll see.....

Trott added a commit that referenced this issue Sep 29, 2023
@Trott
lookup: use GitHub head for serialport (#992)
5892481 
This will hopefully fix serialport when run against a `-pre`
version of Node.js. Eventually, this fix will be in a release
of serialport, but it's in GitHub now.

Closes: #991
@Trott
Copy link
Member

Trott commented Sep 29, 2023

It is (probably) still failing against certain platforms and we'll need to fix or skip those.

@Trott Trott reopened this Sep 29, 2023
@Trott
Copy link
Member

Trott commented Sep 30, 2023

PPC and s390x skipped in 037c204. We're all good.

@reconbot If serialport should compile/run on those platforms, we can investigate further. But if those are unsupported, then obviously skipping is the thing to do and we're good!

@Trott Trott closed this as completed Sep 30, 2023
@reconbot
Copy link
Contributor

reconbot commented Oct 1, 2023

@Trott i only officially support max Linux and windows on x64, arm is a very popular usecase but I don't have an easy way to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lookup: use GitHub head for serialport nodejs/citgm
3 participants
@reconbot @Trott @aduh95