lookup: use GitHub head for serialport #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully fix serialport when run against a `-pre` version of Node.js. Eventually, this fix will be in a release of serialport, but it's in GitHub now. Closes: #991
|
CITGM with this PR: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3283/ |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
|
Still failing on AIX, s390x and RHEL-ppc but now passing everywhere else. (So this fixes it for 6 of 9 operating systems. Even Windows!) I think we should land this and work out whether to skip or fix those other platforms in another PR. |
benjamingr
approved these changes
Sep 29, 2023
jeromecovington
added a commit
to jeromecovington/citgm
that referenced
this pull request
Sep 30, 2023
This skips the remaining platforms that still pose a problem for verifying serialport against a `-pre` version of Node.js Relates: nodejs#992
jeromecovington
added a commit
to jeromecovington/citgm
that referenced
this pull request
Sep 30, 2023
This skips the remaining platforms that still pose a problem for verifying serialport against a `-pre` version of Node.js Relates to: nodejs#992
2 tasks
jeromecovington
added a commit
to jeromecovington/citgm
that referenced
this pull request
Sep 30, 2023
This skips the remaining platforms that still pose a problem for verifying serialport against a `-pre` version of Node.js Relates to: nodejs#992
Trott
pushed a commit
that referenced
this pull request
Sep 30, 2023
This skips the remaining platforms that still pose a problem for verifying serialport against a `-pre` version of Node.js Relates to: #992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully fix serialport when run against a
-preversion of Node.js. Eventually, this fix will be in a release of serialport, but it's in GitHub now.Closes: #991
Checklist
npm testpasseshere