Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: do not use head for csv-parser #1080

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

targos
Copy link
Member

@targos targos commented Dec 21, 2024

The module is not maintained anymore and fails on Node.js >=22 because
its test suite uses the esm module (abandoned and broken).

The module is not maintained anymore and fails on Node.js >=22 because
its test suite uses the `esm` module (abandoned and broken).
@RafaelGSS
Copy link
Member

cc: @mafintosh

@mafintosh
Copy link
Member

Fixed that dependency, so should work on 22 now

@targos targos changed the title lookup: remove csv-parser lookup: do not use head for csv-parser Dec 23, 2024
@targos
Copy link
Member Author

targos commented Dec 23, 2024

@targos
Copy link
Member Author

targos commented Dec 23, 2024

Thanks for the fix!

@targos targos merged commit 2d508ab into nodejs:main Dec 23, 2024
14 checks passed
@targos targos deleted the rm-csv-parser branch December 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants