Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump google-github-actions/release-please-action from 3 to 4 #368

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(deps): bump google-github-actions/release-please-action from 3 to 4 #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e0e65
build(deps): bump google-github-actions/release-please-action
dependabot[bot] Jan 30, 2024
7fe9ad6
Update publish.yml
aduh95 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,10 @@ jobs:
release_created: ${{ steps.release.outputs.release_created }}
release_tag: ${{ steps.release.outputs.tag_name }}
steps:
- uses: google-github-actions/release-please-action@v3
- uses: google-github-actions/release-please-action@v4
id: release
with:
release-type: node
package-name: corepack
bump-minor-pre-major: true # TODO: remove this when releasing v1.0.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this will likely be annoying, unless we are to actually release v1.0.0. The alternative is to setup a manifest, but the docs imply it's not a very straight forward thing to do, so maybe it's best to hold on with this update for the time being.


npm-publish:
needs: release-please
Expand Down