fix: remove explicit installation of setuptools (#278)

nodejs · Dec 29, 2024 · e476778 · e476778
1 parent a61df70
commit e476778
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/node-gyp.yml b/.github/workflows/node-gyp.yml
@@ -33,7 +33,7 @@ jobs:
       - name: Install Python dependencies
         run: |
           cd gyp-next
-          python -m pip install --upgrade pip setuptools
+          python -m pip install --upgrade pip
           pip install --editable .
           pip uninstall -y gyp-next
       - name: Install Node.js dependencies

diff --git a/.github/workflows/python_tests.yml b/.github/workflows/python_tests.yml
@@ -26,7 +26,7 @@ jobs:
       - uses: seanmiddleditch/gha-setup-ninja@v5
       - name: Install dependencies
         run: |
-          python -m pip install --upgrade pip setuptools
+          python -m pip install --upgrade pip
           pip install --editable ".[dev]"
       - run: ./gyp -V && ./gyp --version && gyp -V && gyp --version
       - name: Lint with ruff  # See pyproject.toml for settings

diff --git a/docs/Hacking.md b/docs/Hacking.md
@@ -24,7 +24,7 @@ to make sure your changes aren't breaking anything important.
 You run the test driver with e.g.
 
 ``` sh
-$ python -m pip install --upgrade pip setuptools
+$ python -m pip install --upgrade pip
 $ pip install --editable ".[dev]"
 $ python -m pytest
 ```

diff --git a/pylib/gyp/__init__.py b/pylib/gyp/__init__.py
@@ -696,7 +696,7 @@ def main(args):
         return 1
 
 
-# NOTE: setuptools generated console_scripts calls function with no arguments
+# NOTE: console_scripts calls this function with no arguments
 def script_main():
     return main(sys.argv[1:])