Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare packaging in package discovery #247

Closed
wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Apr 30, 2024

packaging needs to be declared in setuptools package discovery config.

@legendecas legendecas closed this Apr 30, 2024
@legendecas legendecas deleted the packages branch April 30, 2024 12:30
@legendecas legendecas restored the packages branch April 30, 2024 12:38
@legendecas legendecas reopened this Apr 30, 2024
@legendecas legendecas changed the title chore: add packaging to publish archives chore: declare packaging in package discovery Apr 30, 2024
@legendecas legendecas requested a review from cclauss April 30, 2024 12:41
@legendecas legendecas changed the title chore: declare packaging in package discovery fix: declare packaging in package discovery Apr 30, 2024
@cclauss
Copy link
Contributor

cclauss commented Apr 30, 2024

@legendecas
Copy link
Member Author

yeah, this seems to publish packaging globally. I dont think this is the correct way.

@legendecas
Copy link
Member Author

@cclauss Would you mind creating a revert on #214? I think packaging should be declared as a required dependency, it can be installed on python < 3.12 as well.

@legendecas legendecas closed this Apr 30, 2024
@legendecas legendecas deleted the packages branch April 30, 2024 13:15
@cclauss
Copy link
Contributor

cclauss commented Apr 30, 2024

The preferred solution is setuptools; python_version >= "3.12"

@legendecas
Copy link
Member Author

That would change the python version requirement of node: https://github.com/nodejs/node/blob/main/BUILDING.md#note-about-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants