Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pyproject.toml: dependencies = ["packaging>=24.0"] #250

Merged
merged 2 commits into from
May 6, 2024
Merged

chore: pyproject.toml: dependencies = ["packaging>=24.0"] #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b765dc
chore: pyproject.toml: dependencies = ["packaging>=24.0"]
cclauss May 5, 2024
fdf5895
Merge branch 'main' into pyproject.toml-dependencies=packaging
cclauss May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ description = "A fork of the GYP build system for use in the Node.js projects"
readme = "README.md"
license = { file="LICENSE" }
requires-python = ">=3.8"
# The Python module "packaging" is vendored in the "pylib/packaging" directory to support Python >= 3.12.
# dependencies = ["packaging>=23.1"] # Uncomment this line if the vendored version is removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the vendored packaging source code as well?

Copy link
Contributor Author

@cclauss cclauss May 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to do this in two steps even if there is a bit of duplication.

dependencies = ["packaging>=24.0"]
classifiers = [
"Development Status :: 3 - Alpha",
"Environment :: Console",
Expand All @@ -29,7 +28,7 @@ classifiers = [
]

[project.optional-dependencies]
dev = ["flake8", "ruff == 0.4.3", "pytest"]
dev = ["pytest", "ruff"]

[project.scripts]
gyp = "gyp:script_main"
Expand Down
Loading