-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove EoL Node.js 16 from test matrix #733
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 83.03% 83.00% -0.03%
==========================================
Files 37 37
Lines 4178 4184 +6
==========================================
+ Hits 3469 3473 +4
- Misses 709 711 +2 ☔ View full report in Codecov by Sentry. |
Can you please update the "engines" field in package.json as well? |
Totally not necessary for this PR but optional here or as a future enhancement: If we use the pkgjs prepare-node-test-matrix GitHub Action instead of hardcoding the Node.js version numbers, it will look at the "engines" property in package.json and only test the LTS versions at or above that level along with the current version. See https://github.com/pkgjs/action/tree/main for more information. (pkgjs is the tooling org managed in a very hands-off way by the TSC for Node.js.) |
@Trott moved to |
Co-authored-by: Antoine du Hamel <[email protected]>
No description provided.