Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --skip-more-than to ncu-ci and show console URL for "Appeared on" #741

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 3, 2023

feat: add --skip-more-than to ncu-ci to skip real test failures

fix: link to failure console for "Appeared on" in ncu-ci

Because it's more useful than the computer URL.
Also use CI URL for PRs instead of the PR URLs themselves.

Because it's more useful than the computer URL.
Also use CI URL for PRs instead of the PR URLs themselves.
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f30cdba) 83.38% compared to head (575d5ce) 82.95%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   83.38%   82.95%   -0.43%     
==========================================
  Files          37       37              
  Lines        4158     4190      +32     
==========================================
+ Hits         3467     3476       +9     
- Misses        691      714      +23     
Files Coverage Δ
lib/ci/build-types/pr_build.js 92.07% <100.00%> (ø)
lib/links.js 91.86% <50.00%> (ø)
lib/ci/build-types/commit_build.js 77.96% <57.14%> (-1.50%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung merged commit 90674b5 into nodejs:main Oct 5, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants