Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is a draft feedback request for adding baseline ninja support to
node-gyp
.gyp
already supportsninja
out of the box, so this installs ninja to a user's computer if it doesn't exist, and then allows for its use when the--ninja
flag is passed.This is motivated by work i did recently to support Swift compilation using
node-gyp
: https://github.com/codebytere/node-mac-swift-addon and this commit.The whole patchset is likely untenable to upstream, so I'd like just to seek feedback on this portion at this point!
Tests and documentation would come after initial feedback on the potential path forward here.
cc @rvagg
Checklist
npm install && npm test
passes