Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: find extensive Win10SDK installation #2259

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mcdmaster
Copy link

May close #2234

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Added facility to detect extensive installations of Windows 10 SDK. In previous version, only SDK version which comes out of the VS Installer menu list were accepted, because it can go to MS VS Workload like: Microsoft.VisualStudio.Component.Windows10SDK.18362.

Contrarily, post-installation SDKs, preferred by early-adopting developers, have not been detected in command inputs like node-gyp configure. This circumstance has slowed down the progress of entire development activities using Node components.

DeeDeeG and others added 7 commits September 1, 2020 13:14
This isn't needed, and was probably copy-pasted from
windows-build-tools' README.md, which has since been changed
to drop the `--production` flag from the install instructions.

Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Matias Lopez <[email protected]>
PR-URL: nodejs#2210
Closes: nodejs#2127
Closes: nodejs#2209
PR-URL: nodejs#2218
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Matias Lopez <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuilds Problem (Win10 Insider Preview)
4 participants