Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build.js remove comments issue #2324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix build.js remove comments issue #2324

wants to merge 1 commit into from

Conversation

diegozhu
Copy link

@diegozhu diegozhu commented Feb 7, 2021 •
edited by cclauss
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

some user may use git Windows-style line-ending which will result in JSON.parse error.

@cclauss cclauss requested review from joaocgreis and rvagg February 7, 2021 11:05
rvagg
rvagg requested changes Feb 9, 2021
View reviewed changes
lib/build.js Outdated Show resolved Hide resolved
@lukekarrys lukekarrys self-assigned this Oct 28, 2023
@diegozhu @lukekarrys
fix: build.js remove comments issue
7033e6a 
some user may use git Windows-style line-ending which will result in JSON.parse error.
@lukekarrys
Copy link
Member

I committed the suggested change and rebased against main to get CI running and tests are now failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys left review comments

@rvagg rvagg rvagg requested changes

@joaocgreis joaocgreis Awaiting requested review from joaocgreis

Assignees

@lukekarrys lukekarrys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegozhu @lukekarrys @rvagg