Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failure when build directory contains spaces (#65) #2556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davej
Copy link

@davej davej commented Nov 25, 2021

Checklist
  • npm install && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

Before this fix, if the build directory had a space in the path then it would fail because spaces were not escaped properly. Happy to add a test for this if anyone has a suggestion for how I should test this? Had a brief look through the existing tests and it wasn't clear to me how I should test this functionality.

@cclauss
Copy link
Contributor

cclauss commented Jun 28, 2022

I would strongly suggest the creation of a GitHub Action that fails because of a space in the pathname. Then we can demonstrate that this code fixes the failing test.

@gjsjohnmurray
Copy link

Getting this merged and into a new release should fix an issue seen on macOS in mtxr/vscode-sqltools#921 where the sqlite3 package gets downloaded into a subfolder of ~/Library/Application Support/ and then has to build its binaries, uses node-gyp to do this, and fails because of the space in the path.

@recrsn
Copy link

recrsn commented Oct 6, 2022

@davej The node-gyp project simply vendors the gyp-next so maybe we should raise a PR against https://github.com/nodejs/gyp-next/blob/main/pylib/gyp/generator/make.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants