Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update example to reflect proper argument usage #2718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itsknob
Copy link

@itsknob itsknob commented Aug 11, 2022

The example had a space instead of an equals sign (=) where the table below specifies that the argument should utilize an equals sign (=) for it's key-value flags.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

The example had a space instead of an equals sign (=) where the table below specifies that the argument should utilize an equals sign (=) for it's key-value flags.
@cclauss
Copy link
Contributor

cclauss commented Oct 17, 2022

Does it work either way or does only one way work? On Linux, macOS, and Windows?

@itsknob
Copy link
Author

itsknob commented Oct 17, 2022

Since I opened this a while ago, my memory is a little fuzzy. I think the best information I have for you is this screenshot. This is MacOS on an M1 Chip. After specifying the Python 2.7 path as an arg without an equals sign (=), it seems as though the node-gyp utilized the Python 3 installation.

image

All other arguments in the docs used an equals sign. I'm not entirely sure that the cause for using the wrong python version was due to the lack of the equals sign, but this MR was more just to standardize the way the arguments are laid out in the documentation.

@cclauss
Copy link
Contributor

cclauss commented Oct 17, 2022

Node-gyp is using Python 3 because Python 2 died more than 1,000 days ago on 1/1/2020.

@itsknob
Copy link
Author

itsknob commented Oct 17, 2022

Legacy software still exists, I was installing node-gyp 3.8 for an application running node 12. While I understand that it's not supported, this isn't a bug report. It's a docs consistency update.

If this doesn't seem relevant or worth the effort, feel free to close this.

@cclauss
Copy link
Contributor

cclauss commented Oct 17, 2022

node-gyp 3.8 loves legacy Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants