-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 9.4.1 #2878
chore: release 9.4.1 #2878
Conversation
This shouldn't be released in it's current state. #2770 landed with a breaking change but isn't formatted like a conventional commit, so it didn't trigger this PR to be |
5ff88f7
to
fc52860
Compare
@lukekarrys Do you think we can consider #2849 for inclusion into a Then a more long-term solution which doesn't need to consider 12.x support can be targeting a 10.x release. |
ebae5d2
to
a43758d
Compare
a43758d
to
0c82104
Compare
0c82104
to
b13c7a2
Compare
ee68a4f
to
5c042ee
Compare
If someone does |
5c042ee
to
83194aa
Compare
Hi - is there any documentation on release processes here / when we can hope the latest |
There is not any current documentation @mfranzs. But my goal is to release the latest |
Thank you very much! |
@lukekarrys any chance we can actually get a 9.x release? LMK if you see any blockers or other things you would need assistance with to make that happen.
|
Stuff to consider doing before releasing?EDIT: Besides @legobeat's point above (which I don't want to bury with my comment so shortly after)... Might want to resolve concerns mentioned in #2857 (comment) before releasing? This bit:
Would be good not to impose backward-compatibility guarantees on any stuff that depends on a particular How to release / How to set the semver for the releaseAnd (at least for stuff that happens on GitHub) the release process is basically https://github.com/google-github-actions/release-please-action#readme --> https://github.com/googleapis/release-please#readme. (And after that, I'm sure some maintainer(s) here know about how publishing the new version to the npm package registry works.) You can manually set the version number (like I did the PR to add release-please to this repo at the request of multiple active node-gyp contributors at the time, so if I can be of help by answering questions why it was set up any particular way I am happy to do so, but it was set up kind of arbitrarily just to make releases more automated than the existing process, to put it in a nutshell. |
83194aa
to
fe2af11
Compare
5d0471f
to
e62ac4f
Compare
e62ac4f
to
0b6fe55
Compare
I'm going to close this release PR so that when #2917 lands in We can also use the new |
🤖 I have created a release *beep* *boop*
9.4.1 (2023-10-27)
Bug Fixes
Core
Tests
Doc
This PR was generated with Release Please. See documentation.