feat: add VCToolsVersion for msvs (#2906)

[tr-takatsuka]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Add the ability to specify the 'MSVC toolset version' <VCToolsVersion> for the VisualStudio platform.

Usage example for binding.gyp

'targets': [
 {
   'configurations': {
     'Debug': {
       "msvs_configuration_attributes": {
         "VCToolsVersion": "14.36.32532",

---

ps. The following FAILED is displayed in npm test, but I think it is unrelated to this case.

  Failed test details
    1.'addon build simple addon in path with non-ascii characters'
      Name: TypeError
      Message: Callback must be a function. Received undefined
      Code: ERR_INVALID_CALLBACK
      Stack: TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received undefined

---

Thank you and best regards.

[cclauss]

@rzhao271 @ryzokuken Please review. Would this land in this repo or in https://github.com/nodejs/gyp-next and then get vendored back into this repo?

[rzhao271]

PR LGTM. Any change made to a gyp folder in this repo can be backported to gyp-next, whereas any change made to gyp-next would need to wait for another patch release to be brought back to here. At the same time, I've been putting gyp changes in gyp-next first.

[cclauss]

That is as clear as mud to me.

[rzhao271]

I recommend first creating this PR in nodejs/gyp-next unless anyone has any objections.

[tr-takatsuka]

Thank you all for your advice.

I am not yet knowledgeable enough about gyp-next, but I understand that submitting a pull request to gyp-next is the right way to go.

I will try my best to submit a pull request to gyp-next.

Hopefully this will be reflected in node-gyp as soon as possible.

[StefanStojanovic]

I recommend first creating this PR in nodejs/gyp-next unless anyone has any objections.

I also agree with this approach. The change itself looks good to me. 👍

[cclauss]

@StefanStojanovic Please go to https://github.com/nodejs/node-gyp/pull/2910/files and in the upper right click on Review files --> Approve --> Submit review

[StefanStojanovic]

@cclauss I thought we were going to make this change in nodejs/gyp-next? In that case, does it make sense to approve this PR here?

[StefanStojanovic]

Closing this, since nodejs/gyp-next#209 landed. Thank you @tr-takatsuka for the initiative!