feat: define common_gypi_dir
when running node-gyp configure
#2973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm test
passesDescription of change
Refs:
I'm trying to add node-gyp support to emnapi, some upstream changes are made in nodejs/gyp-next#222. I'd like to add the linker option
--js-library=<(common_gypi_dir)/dist/library_napi.js
in emnapi'scommon.gypi
' (used via--nodedir
). The--js-library
need to receive an absolute path because relative path doesn't work whenemcc
runs innode-gyp build
stage the CWD is${projectRoot}/build
. But I can't find a way to set the--js-library
relative to thenodedir
orcommon_gypi_dir
. See nodejs/gyp-next#222 (comment) for more detail description about this. I know there are<(node_root_dir)
and<(nodedir)
, but there is no guarantee that they are absolute path.Adding a
-D
affects almost nothing. It would be great if someone could tell that there is a better way.