feat(gyp): update gyp to v0.18.1 #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@legendecas wasm integration tests are added in this PR. |
2 tasks
legendecas
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Would you mind setting up python with 3.12 in https://github.com/nodejs/node-gyp/blob/main/.github/workflows/visual-studio.yml?
nodejs/gyp-next#222 uses the colon-equals syntax which is only supported since python 3.8. I think https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation stated that the supported python version is 3.12.
|
Done. |
legendecas
approved these changes
Jun 7, 2024
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
* feat(gyp): update gyp to v0.18.1 * ci: setup ninja * ci: visual-studio job use python 3.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassestests are included(moved to Supportrebuildandbuildfor cross-compiling Node-API module to wasm on Windows #2974)Description of change
Refs
#2974
nodejs/gyp-next#222
nodejs/gyp-next#240