http2, tls: check content-length, fix RST and GOAWAY logic #57055
Annotations
4 errors
|
Test:
test/parallel/test-http2-server-session-destroy.js#L1
--- stderr ---
node:assert:644
throw err;
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
Comparison {
code: 'ERR_HTTP2_STREAM_ERROR',
+ message: 'Stream closed with error code NGHTTP2_CANCEL',
- message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR',
name: 'Error'
}
at ServerHttp2Stream.<anonymous> (/home/runner/work/node/node/test/common/index.js:719:12)
at ServerHttp2Stream.<anonymous> (/home/runner/work/node/node/test/common/index.js:466:15)
at Object.onceWrapper (node:events:635:26)
at ServerHttp2Stream.emit (node:events:520:28)
at emitErrorNT (node:internal/streams/destroy:170:8)
at emitErrorCloseNT (node:internal/streams/destroy:129:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_CANCEL
at ServerHttp2Stream._destroy (node:internal/http2/core:2392:13)
at _destroy (node:internal/streams/destroy:122:10)
at ServerHttp2Stream.destroy (node:internal/streams/destroy:84:5)
at Writable.destroy (node:internal/streams/writable:1113:11)
at [kMaybeDestroy] (node:internal/http2/core:2418:14)
at ServerHttp2Stream.<anonymous> (node:internal/http2/core:1883:28)
at ServerHttp2Stream.emit (node:events:520:28)
at finish (node:internal/streams/writable:946:10)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'ERR_HTTP2_STREAM_ERROR'
},
expected: {
name: 'Error',
code: 'ERR_HTTP2_STREAM_ERROR',
message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'
},
operator: 'throws'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http2-server-session-destroy.js
|
|
Test:
test/parallel/test-http2-server-socket-destroy.js#L1
--- stderr ---
node:assert:644
throw err;
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
Comparison {
+ code: 'ERR_HTTP2_STREAM_ERROR',
+ message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR',
- code: 'ECONNRESET',
- message: 'read ECONNRESET',
name: 'Error'
}
at ClientHttp2Stream.<anonymous> (/home/runner/work/node/node/test/common/index.js:719:12)
at ClientHttp2Stream.<anonymous> (/home/runner/work/node/node/test/common/index.js:466:15)
at ClientHttp2Stream.emit (node:events:532:35)
at emitErrorNT (node:internal/streams/destroy:170:8)
at emitErrorCloseNT (node:internal/streams/destroy:129:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_INTERNAL_ERROR
at ClientHttp2Stream._destroy (node:internal/http2/core:2392:13)
at _destroy (node:internal/streams/destroy:122:10)
at ClientHttp2Stream.destroy (node:internal/streams/destroy:84:5)
at Writable.destroy (node:internal/streams/writable:1113:11)
at Http2Stream.onStreamClose (node:internal/http2/core:562:12) {
code: 'ERR_HTTP2_STREAM_ERROR'
},
expected: { name: 'Error', code: 'ECONNRESET', message: 'read ECONNRESET' },
operator: 'throws'
}
Node.js v23.0.0-pre
Command: out/Release/node --expose-internals --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/parallel/test-http2-server-socket-destroy.js
|
|
Test:
test/benchmark/test-benchmark-http2.js#L1
--- stderr ---
node:events:498
throw er; // Unhandled 'error' event
^
Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_CANCEL
at ClientHttp2Stream._destroy (node:internal/http2/core:2392:13)
at _destroy (node:internal/streams/destroy:122:10)
at ClientHttp2Stream.destroy (node:internal/streams/destroy:84:5)
at Writable.destroy (node:internal/streams/writable:1113:11)
at node:internal/http2/core:1175:46
at Map.forEach (<anonymous>)
at closeSession (node:internal/http2/core:1175:19)
at ClientHttp2Session.destroy (node:internal/http2/core:1566:5)
at ClientHttp2Stream.<anonymous> (/home/runner/work/node/node/benchmark/http2/headers.js:48:18)
at ClientHttp2Stream.emit (node:events:532:35)
Emitted 'error' event on ClientHttp2Stream instance at:
at emitErrorNT (node:internal/streams/destroy:170:8)
at emitErrorCloseNT (node:internal/streams/destroy:129:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'ERR_HTTP2_STREAM_ERROR'
}
Node.js v23.0.0-pre
node:assert:126
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
1 !== 0
at ChildProcess.<anonymous> (/home/runner/work/node/node/test/common/benchmark.js:28:12)
at ChildProcess.emit (node:events:520:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: 1,
expected: 0,
operator: 'strictEqual'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/test/benchmark/test-benchmark-http2.js
|
|
Test
Process completed with exit code 2.
|
Loading