net: rework test approach

test/internet/test-net-autoselectfamily-events.js → test/internet/test-net-autoselectfamily-events-failure.js

@@ -7,7 +7,16 @@ const { createMockedLookup } = require('../common/dns');
 const assert = require('assert');
 const { createConnection } = require('net');
 
-// Test that all events are emitted when trying a single IP (which means autoselectfamily is bypassed)
+//
+// When testing this is MacOS, remember that the last connection will have no timeout at Node.js
+// level but only at operating system one.
+//
+// The default for MacOS is 75 seconds. It can be changed by doing:
+//
+// sudo sysctl net.inet.tcp.keepinit=VALUE_IN_MS
+//
+
+// Test that all failure events are emitted when trying a single IP (which means autoselectfamily is bypassed)
 {
   const connection = createConnection({
     host: 'example.org',
@@ -28,7 +37,10 @@ const { createConnection } = require('net');
     assert.strictEqual(port, 10);
     assert.strictEqual(family, 4);
 
-    assert.ok(error.code.match(/ECONNREFUSED|ENETUNREACH|EHOSTUNREACH|ETIMEDOUT/));
+    assert.ok(
+      error.code.match(/ECONNREFUSED|ENETUNREACH|EHOSTUNREACH|ETIMEDOUT/),
+      `Received unexpected error code ${error.code}`,
+    );
   }));
 
   connection.on('ready', common.mustNotCall());
@@ -67,36 +79,12 @@ const { createConnection } = require('net');
     assert.strictEqual(port, expected.port);
     assert.strictEqual(family, expected.family);
 
-    assert.ok(error.code.match(/ECONNREFUSED|ENETUNREACH|EHOSTUNREACH|ETIMEDOUT/), `Received unexpected error code ${error.code}`);
+    assert.ok(
+      error.code.match(/ECONNREFUSED|ENETUNREACH|EHOSTUNREACH|ETIMEDOUT/),
+      `Received unexpected error code ${error.code}`,
+    );
   }, 2));
 
   connection.on('ready', common.mustNotCall());
   connection.on('error', common.mustCall());
 }
-
-// Test that if a connection attempt times out and the socket is destroyed before the
-// next attempt starts then the process does not crash
-{
-  const connection = createConnection({
-    host: 'example.org',
-    port: 443,
-    lookup: createMockedLookup(INET4_IP, INET6_IP),
-    autoSelectFamily: true,
-    autoSelectFamilyAttemptTimeout: 10,
-  });
-
-  // Depending on the network, it might be impossible to obtain a timeout in 10ms,
-  // which is the minimum value allowed by network family autoselection.
-  // At the time of writing (Dec 2023), the network times out on local machine and in the Node CI,
-  // but it does not on GitHub actions runner.
-  // Therefore, we allow both a timeout or a successfull connections as pass.
-
-  connection.on('connectionAttemptTimeout', (address, port, family) => {
-    assert.strictEqual(address, INET4_IP);
-    assert.strictEqual(port, 443);
-    assert.strictEqual(family, 4);
-    connection.destroy();
-  });
-
-  connection.on('ready', () => connection.destroy());
-}

test/internet/test-net-autoselectfamily-events-timeout.js

@@ -0,0 +1,49 @@
+'use strict';
+
+const common = require('../common');
+const { addresses: { INET6_IP, INET4_IP } } = require('../common/internet');
+const { createMockedLookup } = require('../common/dns');
+
+const assert = require('assert');
+const { createConnection } = require('net');
+
+//
+// When testing this is MacOS, remember that the last connection will have no timeout at Node.js
+// level but only at operating system one.
+//
+// The default for MacOS is 75 seconds. It can be changed by doing:
+//
+// sudo sysctl net.inet.tcp.keepinit=VALUE_IN_MS
+//
+
+// Test that if a connection attempt times out and the socket is destroyed before the
+// next attempt starts then the process does not crash
+{
+  const connection = createConnection({
+    host: 'example.org',
+    port: 443,
+    lookup: createMockedLookup(INET4_IP, INET6_IP),
+    autoSelectFamily: true,
+    autoSelectFamilyAttemptTimeout: 10,
+  });
+
+  const pass = common.mustCall();
+
+  connection.on('connectionAttemptTimeout', (address, port, family) => {
+    assert.strictEqual(address, INET4_IP);
+    assert.strictEqual(port, 443);
+    assert.strictEqual(family, 4);
+    connection.destroy();
+    pass()
+  });
+
+  // Depending on the network, it might be impossible to obtain a timeout in 10ms,
+  // which is the minimum value allowed by network family autoselection.
+  // At the time of writing (Dec 2023), the network times out on local machine and in the Node CI,
+  // but it does not on GitHub actions runner.
+  // Therefore, after five seconds we just consider this test as passed.
+  setTimeout(() => {
+    pass()
+    process.exit(0)
+  }, 5000).unref()
+}