Skip to content

Commit

Permalink
remove debug
Browse files Browse the repository at this point in the history
  • Loading branch information
arcanis committed Sep 10, 2024
1 parent e543254 commit 75a276c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions doc/api/http2.md
Original file line number Diff line number Diff line change
Expand Up @@ -2768,6 +2768,7 @@ added: v8.4.0
changes:
- version:
- REPLACEME
pr-url: https://github.com/nodejs/node/pull/54875
description: Added `streamResetBurst` and `streamResetRate`.
- version:
- v15.10.0
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/http2/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ function updateOptionsBuffer(options) {
optionsBuffer[IDX_OPTIONS_STREAM_RESET_RATE] =
MathMax(1, options.streamResetRate);
}
if (typeof options.streamResetBurstLimit === 'number') {
if (typeof options.streamResetBurst === 'number') {
flags |= (1 << IDX_OPTIONS_STREAM_RESET_BURST);
optionsBuffer[IDX_OPTIONS_STREAM_RESET_BURST] =
MathMax(1, options.streamResetBurst);
Expand Down
5 changes: 3 additions & 2 deletions src/node_http2.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const Http2Session::Callbacks Http2Session::callback_struct_saved[2] = {
// When the Http2Scope passes out of scope and is deconstructed, it will
// call Http2Session::MaybeScheduleWrite().
Http2Scope::Http2Scope(Http2Stream* stream) : Http2Scope(stream->session()) {}
#include <iostream>

Http2Scope::Http2Scope(Http2Session* session) : session_(session) {
if (!session_) return;

Expand Down Expand Up @@ -209,7 +209,8 @@ Http2Options::Http2Options(Http2State* http2_state, SessionType type) {
static_cast<size_t>(buffer[IDX_OPTIONS_MAX_SETTINGS]));
}

if ((flags & (1 << IDX_OPTIONS_STREAM_RESET_BURST)) && (flags & (1 << IDX_OPTIONS_STREAM_RESET_RATE))) {
if ((flags & (1 << IDX_OPTIONS_STREAM_RESET_BURST)) &&
(flags & (1 << IDX_OPTIONS_STREAM_RESET_RATE))) {
nghttp2_option_set_stream_reset_rate_limit(
option,
static_cast<uint64_t>(buffer[IDX_OPTIONS_STREAM_RESET_BURST]),
Expand Down

0 comments on commit 75a276c

Please sign in to comment.