Skip to content

Commit

Permalink
test: remove deprecated v8 flag from nodejs test
Browse files Browse the repository at this point in the history
test-cli-node-options.js is checking the existance of a
`--huge-max-old-generation-size` V8 flag. That flag was recently
deprected (it currently remains as nop, see crrev.com/c/5831467)
and will soon be completely removed.
  • Loading branch information
omerktz committed Sep 19, 2024
1 parent 70de19e commit b2abfc4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -3096,7 +3096,6 @@ V8 options that are allowed are:
* `--disallow-code-generation-from-strings`
* `--enable-etw-stack-walking`
* `--expose-gc`
* `--huge-max-old-generation-size`
* `--interpreted-frames-native-stack`
* `--jitless`
* `--max-old-space-size`
Expand Down Expand Up @@ -3430,8 +3429,6 @@ documented here:

### `--harmony-shadow-realm`

### `--huge-max-old-generation-size`

### `--jitless`

### `--interpreted-frames-native-stack`
Expand Down
5 changes: 0 additions & 5 deletions src/node_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -900,11 +900,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
"disallow eval and friends",
V8Option{},
kAllowedInEnvvar);
AddOption("--huge-max-old-generation-size",
"increase default maximum heap size on machines with 16GB memory "
"or more",
V8Option{},
kAllowedInEnvvar);
AddOption("--jitless",
"disable runtime allocation of executable memory",
V8Option{},
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-cli-node-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ if (common.hasCrypto) {
expect('--abort_on-uncaught_exception', 'B\n');
expect('--disallow-code-generation-from-strings', 'B\n');
expect('--expose-gc', 'B\n');
expect('--huge-max-old-generation-size', 'B\n');
expect('--jitless', 'B\n');
expect('--max-old-space-size=0', 'B\n');
expect('--max-semi-space-size=0', 'B\n');
Expand Down

0 comments on commit b2abfc4

Please sign in to comment.