Skip to content

Commit

Permalink
lib: implement interface converter in webidl
Browse files Browse the repository at this point in the history
  • Loading branch information
jazelly committed Sep 16, 2024
1 parent 53ede87 commit b87578f
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 1 deletion.
18 changes: 17 additions & 1 deletion lib/internal/webidl.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const {
NumberMAX_SAFE_INTEGER,
NumberMIN_SAFE_INTEGER,
ObjectAssign,
ObjectPrototypeIsPrototypeOf,
SafeSet,
String,
SymbolIterator,
Expand All @@ -20,6 +21,7 @@ const {

const {
codes: {
ERR_INVALID_ARG_TYPE,
ERR_INVALID_ARG_VALUE,
},
} = require('internal/errors');
Expand Down Expand Up @@ -275,20 +277,34 @@ function createSequenceConverter(converter) {
const val = converter(res.value, {
__proto__: null,
...opts,
context: `${opts.context}, index ${array.length}`,
context: `${opts.context}[${array.length}]`,
});
ArrayPrototypePush(array, val);
};
return array;
};
}

// https://webidl.spec.whatwg.org/#js-interface
function createInterfaceConverter(name, prototype) {
return (V, opts = kEmptyObject) => {
// 1. If V implements I, then return the IDL interface type value that
// represents a reference to that platform object.
if (ObjectPrototypeIsPrototypeOf(prototype, V)) return V;
// 2. Throw a TypeError.
throw new ERR_INVALID_ARG_TYPE(
typeof opts.context === 'string' ? opts.context : '', name, V,
);
};
}


module.exports = {
type,
converters,
convertToInt,
createEnumConverter,
createInterfaceConverter,
createSequenceConverter,
evenRound,
makeException,
Expand Down
35 changes: 35 additions & 0 deletions test/parallel/test-internal-webidl.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// Flags: --expose-internals
'use strict';

require('../common');
const { describe, it } = require('node:test');
const assert = require('node:assert');
const { createInterfaceConverter } = require('internal/webidl');

describe('internal/webidl', () => {
class Test { t() {} }
class SubTest extends Test {}
const testConverter = createInterfaceConverter('Test', Test.prototype);

it('converts objects that implement the required interface', () => {
const subTest = new SubTest();
const test = new Test();
assert.strictEqual(subTest, testConverter(subTest));
assert.strictEqual(test, testConverter(test));
});

it('throws TypeError when converting objects that do not implement the required interface', () => {
const expectedError = { code: 'ERR_INVALID_ARG_TYPE' };
[
{ t: () => {} },
null,
undefined,
{},
[],
1,
'123',
].forEach((c) => {
assert.throws(() => { testConverter(c); }, expectedError);
});
});
});

0 comments on commit b87578f

Please sign in to comment.