Skip to content

Commit

Permalink
test: increase spin for eventloop test on s390
Browse files Browse the repository at this point in the history
It was excluded as it was failing intermittently. Likely
that s390 was just so fast times were rounded down to 0.

Increase the spin time on s390x only.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #56228
Refs: #41286
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
  • Loading branch information
mhdawson committed Dec 24, 2024
1 parent 5ea6fa7 commit be9dc2d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,3 @@ test-tls-securepair-client: PASS, FLAKY
[$arch==arm]
# https://github.com/nodejs/node/issues/49933
test-watch-mode-inspect: SKIP

[$arch==s390x]
# https://github.com/nodejs/node/issues/41286
test-performance-eventloopdelay: PASS, FLAKY
5 changes: 5 additions & 0 deletions test/sequential/test-performance-eventloopdelay.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

const common = require('../common');
const assert = require('assert');
const os = require('os');
const {
monitorEventLoopDelay
} = require('perf_hooks');
Expand Down Expand Up @@ -51,9 +52,13 @@ const { sleep } = require('internal/util');
}

{
const s390x = os.arch() === 's390x';
const histogram = monitorEventLoopDelay({ resolution: 1 });
histogram.enable();
let m = 5;
if (s390x) {
m = m * 2;
}
function spinAWhile() {
sleep(1000);
if (--m > 0) {
Expand Down

0 comments on commit be9dc2d

Please sign in to comment.