commit lint should fail

nodejs · Nov 4, 2023 · c70866b · c70866b
1 parent 94156e3
commit c70866b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml
@@ -36,6 +36,7 @@ permissions:
 
 jobs:
   build-tarball:
+    needs: linters
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml
@@ -22,6 +22,7 @@ permissions:
 
 jobs:
   lint-addon-docs:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -37,6 +38,7 @@ jobs:
       - name: Lint addon docs
         run: NODE=$(command -v node) make lint-addon-docs
   lint-cpp:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -52,6 +54,7 @@ jobs:
       - name: Lint C/C++ files
         run: make lint-cpp
   format-cpp:
+    needs: lint-cpp
     if: ${{ github.event.pull_request && github.event.pull_request.draft == false && github.base_ref == github.event.repository.default_branch }}
     runs-on: ubuntu-latest
     steps:
@@ -90,6 +93,7 @@ jobs:
             exit "$EXIT_CODE"
           fi
   lint-js-and-md:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -115,6 +119,7 @@ jobs:
         env:
           NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }}
   lint-py:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -132,6 +137,7 @@ jobs:
           make lint-py-build
           make lint-py
   lint-yaml:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -150,6 +156,7 @@ jobs:
           make lint-yaml
 
   lint-sh:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -160,6 +167,7 @@ jobs:
       - name: Lint Shell scripts
         run: tools/lint-sh.mjs .
   lint-codeowners:
+    needs: commit-lint
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
@@ -170,6 +178,7 @@ jobs:
         with:
           checks: files,duppatterns
   lint-pr-url:
+    needs: commit-lint
     if: ${{ github.event.pull_request }}
     runs-on: ubuntu-latest
     steps: