domain: eol deprecate MakeCallback with domain property

nodejs · Sep 20, 2024 · c966a22 · c966a22
1 parent 8b8fc53
commit c966a22
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 102 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -2087,12 +2087,15 @@ Type: Runtime
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55034
+    description: End-of-Life.
   - version: v10.0.0
     pr-url: https://github.com/nodejs/node/pull/17417
     description: Runtime deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
 Users of `MakeCallback` that add the `domain` property to carry context,
 should start using the `async_context` variant of `MakeCallback` or

diff --git a/lib/domain.js b/lib/domain.js
@@ -136,25 +136,8 @@ process.setUncaughtExceptionCaptureCallback = function(fn) {
   throw err;
 };
 
-
-let sendMakeCallbackDeprecation = false;
-function emitMakeCallbackDeprecation({ target, method }) {
-  if (!sendMakeCallbackDeprecation) {
-    process.emitWarning(
-      'Using a domain property in MakeCallback is deprecated. Use the ' +
-      'async_context variant of MakeCallback or the AsyncResource class ' +
-      'instead. ' +
-      `(Triggered by calling ${method?.name || '<anonymous>'} ` +
-      `on ${target?.constructor?.name}.)`,
-      'DeprecationWarning', 'DEP0097');
-    sendMakeCallbackDeprecation = true;
-  }
-}
-
 function topLevelDomainCallback(cb, ...args) {
   const domain = this.domain;
-  if (exports.active && domain)
-    emitMakeCallbackDeprecation({ target: this, method: cb });
 
   if (domain)
     domain.enter();

diff --git a/test/addons/make-callback-domain-warning/binding.cc b/test/addons/make-callback-domain-warning/binding.cc
diff --git a/test/addons/make-callback-domain-warning/binding.gyp b/test/addons/make-callback-domain-warning/binding.gyp
diff --git a/test/addons/make-callback-domain-warning/test.js b/test/addons/make-callback-domain-warning/test.js