util: inspect: do not crash on an Error with a regex name

See #56570
nodejs · Jan 12, 2025 · d33853a · d33853a
1 parent 4c27393
commit d33853a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1354,7 +1354,7 @@ function removeDuplicateErrorKeys(ctx, keys, err, stack) {
     for (const name of ['name', 'message', 'stack']) {
       const index = ArrayPrototypeIndexOf(keys, name);
       // Only hide the property in case it's part of the original stack
-      if (index !== -1 && StringPrototypeIncludes(stack, err[name])) {
+      if (index !== -1 && StringPrototypeIncludes(stack, String(err[name]))) {
         ArrayPrototypeSplice(keys, index, 1);
       }
     }

diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -3426,3 +3426,14 @@ assert.strictEqual(
     Object.defineProperty(BuiltinPrototype, 'constructor', desc);
   }
 }
+
+{
+  const error = new Error();
+  const re = /a/g;
+  error.name = re;
+  assert.strictEqual(error.name, re);
+  assert.strictEqual(
+    util.inspect(error),
+    error.stack,
+  );
+}