test: migrate message eval tests from Python to JS #50482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
can you please take a look into failing tests? |
Sure. |
|
@yiyunlei may I take over the pr? This would unblock my pr 💚 #56285 (comment) |
Sure, no problem. |
marco-ippolito
force-pushed
the
migrate-eval-tests
branch
from
d2536ce to
8d17393
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50482 +/- ##
==========================================
+ Coverage 88.01% 88.53% +0.52%
==========================================
Files 653 657 +4
Lines 187728 190395 +2667
Branches 35868 36545 +677
==========================================
+ Hits 165225 168570 +3345
+ Misses 15693 14999 -694
- Partials 6810 6826 +16 |
marco-ippolito
added
the
author ready
juanarbol
approved these changes
Dec 23, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50482 ✔ Done loading data for nodejs/node/pull/50482 ----------------------------------- PR info ------------------------------------ Title test: migrate message eval tests from Python to JS (#50482) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch yiyunlei:migrate-eval-tests -> nodejs:main Labels test, author ready, needs-ci, review wanted Commits 2 - test: migrate message eval tests from Python to JS - fixup Committers 1 - Marco Ippolito <[email protected]> PR-URL: https://github.com/nodejs/node/pull/50482 Reviewed-By: Juan José Arboleda <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50482 Reviewed-By: Juan José Arboleda <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 Oct 2023 05:12:51 GMT ✔ Approvals: 1 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/50482#pullrequestreview-2521162545 ⚠ GitHub cannot link the author of 'test: migrate message eval tests from Python to JS' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-12-23T19:59:06Z: https://ci.nodejs.org/job/node-test-pull-request/64181/ - Querying data for job/node-test-pull-request/64181/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50482 From https://github.com/nodejs/node * branch refs/pull/50482/merge -> FETCH_HEAD ✔ Fetched commits as 56d58654ed60..8d17393258f3 -------------------------------------------------------------------------------- [main 911f4bc792] test: migrate message eval tests from Python to JS Author: Yiyun Lei <[email protected]> Date: Tue Oct 31 01:08:25 2023 -0400 5 files changed, 59 insertions(+), 26 deletions(-) rename test/{message => fixtures/eval}/eval_messages.js (98%) rename test/{message/eval_messages.out => fixtures/eval/eval_messages.snapshot} (72%) rename test/{message => fixtures/eval}/stdin_messages.js (98%) rename test/{message/stdin_messages.out => fixtures/eval/stdin_messages.snapshot} (72%) create mode 100644 test/parallel/test-node-output-eval.mjs [main 8aa7d011fe] fixup Author: Marco Ippolito <[email protected]> Date: Mon Dec 23 17:31:23 2024 +0100 3 files changed, 72 insertions(+), 72 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: migrate message eval tests from Python to JShttps://github.com/nodejs/node/actions/runs/12473287213 |
marco-ippolito
added
the
commit-queue-squash
|
@yiyunlei apparently the automation cannot link the commit back to you, I think due to the email |
marco-ippolito
removed
the
commit-queue-failed
marco-ippolito
force-pushed
the
migrate-eval-tests
branch
from
8d17393 to
1a9af8d
Compare
Migrate the eval tests in the `test/message` folder from Python to JS.
marco-ippolito
force-pushed
the
migrate-eval-tests
branch
from
1a9af8d to
965ba46
Compare
|
I jsut amended the author, the last CI was green CI: https://ci.nodejs.org/job/node-test-pull-request/64181/ |
marco-ippolito
removed
the
commit-queue-squash
marco-ippolito
pushed a commit
that referenced
this pull request
Dec 24, 2024
Migrate the eval tests in the `test/message` folder from Python to JS. PR-URL: #50482 Reviewed-By: Juan José Arboleda <[email protected]>
|
Landed in a9e65f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the eval tests in the
test/messagefolder from Python to JS.