Skip to content

module: improve error message for cjs code in an esm module #53152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

module: improve error message for cjs code in an esm module #53152

wants to merge 2 commits into from

Conversation

DanKaplanSES
Copy link
Contributor

Fixes: #40544

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 25, 2024
@GeoffreyBooth
Copy link
Member

Can you please show the before and after?

@DanKaplanSES
Copy link
Contributor Author

Can you please show the before and after?

Sorry, do you mean you want to see a screenshot of this printed on the console?

@GeoffreyBooth
Copy link
Member

Please provide example code that triggers the error. Copy/paste the error that results from current Node and on your branch.

@DanKaplanSES
Copy link
Contributor Author

@GeoffreyBooth Thanks for clarifying. It may take me a few days, but I'll do that soon.

@aduh95
Copy link
Contributor

aduh95 commented Jun 13, 2024

Can you please address the failure in es-module/test-esm-undefined-cjs-global-like-variables?

@dario-piotrowicz dario-piotrowicz mentioned this pull request Apr 6, 2025
Closed
@dario-piotrowicz
Copy link
Member

Hi @DanKaplanSES given the lack of reply to the last comment and the fact that this PR has been inactive for roughly a year I am adding a stalled label to it so that it can be cleaned up (as per the nodejs policy).

If you intend to finish working on this please do let me know and I will remove the label 🙂

@dario-piotrowicz dario-piotrowicz added the stalled Issues and PRs that are stalled. label Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for replacing require usage with dynamic import
5 participants
@DanKaplanSES @nodejs-github-bot @GeoffreyBooth @aduh95 @dario-piotrowicz