test: add more fixtures for strip-types #54107
Conversation
nodejs-github-bot
added
needs-ci
|
Can you adjust the commit message to be prefixed with "test", and start with an active verb? Basically change the beginning to "test: add". Preferably, "test: add more fixtures for strip-types" |
kevinuehara
force-pushed
the
kevinuehara/adding-more-typescript-support-tests
branch
from
ececa33 to
75ecd7e
Compare
|
Commit message updated @redyetidev <3 Thankss! |
|
Hi @kevinuehara I see fixtures being added, but these fixtures are not being tested |
|
HI @marco-ippolito In fact, these fixtures are testing Typescript's own and unique functionalities (Utility Types). If it were not available there would be an error when compiling for Javascript so it can be considered a test and validation of the new ts support functionality |
I'm not sure I understand. Where can I see those .ts files being executed or tested? |
marco-ippolito
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54107 +/- ##
==========================================
- Coverage 88.06% 87.77% -0.29%
==========================================
Files 651 651
Lines 183386 183386
Branches 35800 35478 -322
==========================================
- Hits 161504 160976 -528
- Misses 15159 15673 +514
- Partials 6723 6737 +14 |
Hi @marco-ippolito! I update this PR with the tests |
|
@redyetidev @marco-ippolito @ErickWendel can review this PR? 🙏 |
|
can you please remove unrelated formatting changes? |
| test('expect error when executing a TypeScript file with generics', async () => { | ||
| const result = await spawnPromisified(process.execPath, [ | ||
| '--experimental-strip-types', | ||
| fixtures.path('typescript/ts/test-generics.ts'), |
There was a problem hiding this comment.
if we are testing paramenter properties, why call it test-generics?
There was a problem hiding this comment.
I call test-generics because I created the Typescript generics fixture. Do you have any suggestions for a name for the file?
There was a problem hiding this comment.
test-parameter-properties?
There was a problem hiding this comment.
good! Thanks! I will change the file name
| strictEqual(result.code, 0); | ||
| }); | ||
|
|
||
| test('execute a TypeScript file with Extract Union Type', async () => { |
There was a problem hiding this comment.
can you move the union test into one?
There was a problem hiding this comment.
you say create a separate test file to test the union?
avivkeller
added
the
commit-queue-squash
|
also can you amend your first 2 commits with the right author? |
I needed to format and break the line due to lint 🤔 |
if it was there it means the lint has passed in the original PR 😄 |
|
@marco-ippolito I'll open a new PR with the updates.... I'm having trouble updating the author on the first two commits. |
In this MR I'm adding more tests created in this PR, testing generics and Utility Types.
This PR makes part of typescript iniciative on Node.
cc: @tniessen @ErickWendel