fs: fix subdirectory detection logic

[avivkeller]

Fixes #54285

Checks that std::filesystem::path::preferred_separator exists after a directory for detecting subdirectories.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (9e6c526) to head (157004e).
Report is 447 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_file.cc	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54288      +/-   ##
==========================================
+ Coverage   87.10%   87.89%   +0.78%     
==========================================
  Files         647      651       +4     
  Lines      181754   183366    +1612     
  Branches    34880    35718     +838     
==========================================
+ Hits       158323   161167    +2844     
+ Misses      16742    15468    -1274     
- Partials     6689     6731      +42     

Files with missing lines	Coverage Δ
src/node_file.cc	76.91% <66.66%> (+0.06%)	⬆️

... and 196 files with indirect coverage changes

[avivkeller]

CI failure appears unrelated

[mcollina]

lgtm

[avivkeller]

This has been author ready for a while, can it land?

[ikemo3]

I'm encountering an issue with the CI job, and I'm not quite sure what it means. Here is the relevant error message:

https://ci.nodejs.org/job/node-test-commit-windows-fanned/65275/console

06:47:00 + git archive --format=tar [email protected]:binary_tmp.git jenkins-node-test-commit-windows-fanned-f777812c7105333bbd212153ddcaaee38b4c1f7c src/node_version.h -o node_version.h.tar
06:47:00 Warning: Permanently added '67.158.54.159' (ED25519) to the list of known hosts.
06:47:00 remote: fatal: no such ref: jenkins-node-test-commit-windows-fanned-f777812c7105333bbd212153ddcaaee38b4c1f7c        
06:47:01 remote: git upload-archive: archiver died with error
06:47:01 fatal: sent error to the client: git upload-archive: archiver died with error

It seems that the git archive command is failing due to a missing reference, but I'm not sure why this is happening or how to resolve it. I don't have the ability to fix CI issues myself, so could someone from the team please take a look?

[avivkeller]

Hi! It just appears that the CI failed to start (I think). If someone could restart the windows machine, it'd help this land, thanks!

[ikemo3]

I’m not an internal member, so I can't restart CI. Could you help?
@mcollina @jasnell @anonrig

[aduh95]

RedYetiDev added the wip Issues and PRs that are still a work in progress. label

@redyetidev please remove the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label as soon as the PR is not ready to land.

[avivkeller]

@jazelly If you want to take this up, feel free too.