Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-inspector-connect-to-main-thread as flaky #54805

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 6, 2024

Have been unable to reproduce the failures locally.

Tracking issue: #54804

@jasnell jasnell requested a review from anonrig September 6, 2024 14:49
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2024
@jasnell jasnell requested a review from mcollina September 6, 2024 14:49
@jasnell
Copy link
Member Author

jasnell commented Sep 6, 2024

Closing in favor of #54802

@jasnell jasnell closed this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (e4fdd0b) to head (1fd93f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54805   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         650      650           
  Lines      182945   182945           
  Branches    35397    35394    -3     
=======================================
+ Hits       160279   160280    +1     
+ Misses      15923    15919    -4     
- Partials     6743     6746    +3     

see 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants