test: execute shell directly for refresh() #55051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
avivkeller
reviewed
Sep 21, 2024
| `require("fs").rmSync("${escapedPath}", { maxRetries: 3, recursive: true, force: true });`, | ||
| ], | ||
| ); | ||
| if (isUnix) { |
There was a problem hiding this comment.
WDYT about adding a version for windows, rmdir [path] /s /q
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55051 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183912 183912
Branches 35865 35866 +1
=======================================
+ Hits 162272 162277 +5
+ Misses 14915 14914 -1
+ Partials 6725 6721 -4 |
|
cc @nodejs/cpp-reviewers @nodejs/tsc would you mind reviewing? |
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if we just called the shell directly to avoid the cost of booting a Node.js instance?
cc @nodejs/build any concerns?